✨ [Frontend] Functions Browser: Permissions and Search #8252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
🧪 CI InsightsHere's what we observed from your CI run for fe75253. 🟢 All jobs passed!But CI Insights is watching 👀 |
odeimaiz
requested review from
GitHK,
bisgaard-itis,
Copilot,
giancarloromeo,
matusdrobuliak66,
pcrespov,
sanderegg and
wvangeit
matusdrobuliak66
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds permissions functionality and search capabilities for Functions in the dashboard. It implements a complete permissions system for Functions similar to other resources, enabling users to share Functions with specific access rights and search through them.
- Enables Functions to be shared with read/write permissions like other resources
- Implements search functionality for Functions
- Adds UI components and backend integration for Function permissions management
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| osparc/ui/list/CollaboratorListItem.js | Adds Function role support and improves permission checking logic |
| osparc/theme/Appearance.js | Adds styling for selectbox arrow component |
| osparc/store/Store.js | Adds search Functions context to store |
| osparc/store/Groups.js | Removes unused curateOrderBy method |
| osparc/store/Functions.js | Adds search, permissions management, and collaboration methods |
| osparc/share/NewCollaboratorsManager.js | Syncs arrow appearance for access rights dropdown |
| osparc/share/Collaborators*.js | Adds default access rights comments and Function collaborator support |
| osparc/share/CollaboratorsFunction.js | New class implementing Function-specific collaboration functionality |
| osparc/desktop/credits/CreditsIndicatorButton.js | Removes unused offset parameter |
| osparc/data/model/Function.js | Adds canIWrite permission checking method |
| osparc/data/Roles.js | Defines Function-specific roles and permissions |
| osparc/data/Resources.js | Adds Function permission API endpoints |
| osparc/dashboard/*.js | Implements Function search UI and context handling |
services/static-webserver/client/source/class/osparc/dashboard/StudyBrowser.js
Show resolved
Hide resolved
giancarloromeo
approved these changes
Aug 25, 2025
|
@Mergifyio queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
odeimaiz
changed the title
…simcore into feature/share-functions
wvangeit
approved these changes
Aug 25, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR extends the Functions Browser with the following functionalities:
Next Step:
Bonus:
Permissions:
Search:
Related issue/s
How to test
Dev-ops